Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typos to CI #441

Merged
merged 4 commits into from
Sep 16, 2023
Merged

Add typos to CI #441

merged 4 commits into from
Sep 16, 2023

Conversation

EricLBuehler
Copy link
Contributor

I added the typos utility to CI, and simplified the enum variants in the BuilderError from #436 .

Description

I added the typos utility to CI (and an exclude file).

I also removed the GEPError as it did not make sense and the 2 others GEPPointee and GEPIndex fit better. The 2 lines which used GEPError have been replaced to use more the descriptive variants.

Related Issue

This is related to #438.

It also resolves what @marcospb19 raised in #436.

How This Has Been Tested

CI, including my new addition to it, is passing.

Checklist

@EricLBuehler
Copy link
Contributor Author

@TheDan64, this PR bundles the adding typos utility and changing some variant names of BuilderError. I did not think it would be a good idea to put them in seperate PRs, but please let me know.

@@ -0,0 +1,9 @@
[default]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's with the underscore prefix? Shouldn't it be .typos.toml?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so that the typos utility treats it as a configuration file.

Copy link
Owner

@TheDan64 TheDan64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TheDan64 TheDan64 merged commit 832c1d8 into TheDan64:master Sep 16, 2023
15 checks passed
@EricLBuehler
Copy link
Contributor Author

Glad to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants